[Logs API] Remove global provider for Logs#1691
Merged
cijothomas merged 13 commits intoopen-telemetry:mainfrom Apr 30, 2024
Merged
[Logs API] Remove global provider for Logs#1691cijothomas merged 13 commits intoopen-telemetry:mainfrom
cijothomas merged 13 commits intoopen-telemetry:mainfrom
Conversation
lalitb
changed the title
lalitb
changed the title
cijothomas
reviewed
Apr 30, 2024
cijothomas
reviewed
Apr 30, 2024
cijothomas
reviewed
Apr 30, 2024
cijothomas
approved these changes
Apr 30, 2024
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
Thanks for reducing public API surface!
This should significantly help us achieve the release goals!
TommyCpp
approved these changes
Apr 30, 2024
Contributor
TommyCpp
left a comment
TommyCpp
left a comment
There was a problem hiding this comment.
LGTM. One nit, feel free to ignore if you don't agree.
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As discussed here - LoggerProviders are not meant for end users to get loggers from. It is only required for the log bridges.
So removing all the global constructs for the logs i.e -
opentelemetry::global::loggeropentelemetry::global::set_logger_provideropentelemetry:global::shutdown_logger_provideropentelemetry::global::logger_provideropentelemetry::global::GlobalLoggerProvideropentelemetry::global::ObjectSafeLoggerProviderMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes