fix: send propagator error to global error handler#1640
Merged
cijothomas merged 3 commits intoopen-telemetry:mainfrom Mar 28, 2024
Merged
fix: send propagator error to global error handler#1640cijothomas merged 3 commits intoopen-telemetry:mainfrom
cijothomas merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
=======================================
- Coverage 68.9% 68.9% -0.1%
=======================================
Files 136 136
Lines 19385 19429 +44
=======================================
+ Hits 13368 13396 +28
- Misses 6017 6033 +16 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
|
57cd692 to
ecd96e5
Compare
cijothomas
approved these changes
Mar 28, 2024
Member
cijothomas
left a comment
There was a problem hiding this comment.
LGTM. Will you be adding similar to the trace_context propagator as well?
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One issue with our propagator setup is when there is an error we usually just return default context and throw the error away.
Changes
propagatorMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes