Use a builder pattern for loggers and tracers#1567
Use a builder pattern for loggers and tracers#1567cijothomas merged 18 commits intoopen-telemetry:mainfrom
Conversation
|
@izquierdo Do you want us to review now, or should we wait till PR is marked non-draft? |
c746b6f to
e176589
Compare
Please wait until the PR is marked as non-draft. However, I made a comment here: #1527 (comment) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
=======================================
- Coverage 69.3% 69.0% -0.3%
=======================================
Files 136 136
Lines 19637 19587 -50
=======================================
- Hits 13610 13525 -85
- Misses 6027 6062 +35 ☔ View full report in Codecov by Sentry. |
a3648ad to
e41fc1e
Compare
2442b8e to
66fe3e6
Compare
|
Let me open this for review as is, with loggers and tracers. Will leave metrics out of this PR. |
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
TommyCpp
left a comment
There was a problem hiding this comment.
LGTM. We probably want to revise the change log as suggested above
cijothomas
left a comment
There was a problem hiding this comment.
Thanks!
I left couple of nit comments to improve changelog, but Looks good overall.
Will you help with replicating this for Meter as well?
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Yes! But in a separate PR |
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Fixes #1527
Design discussion issue (if applicable) #1527
Changes
This is currently just an exploratory PR to aid in the design discussion of the attached issue. May upgrade this PR and submit for review depending on the discussion result.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes