Skip to content

Add missing event timestamps to opentelemetry-stdout#1391

Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom
SkaillZ:fix-missing-event-timestamp
Nov 22, 2023
Merged

Add missing event timestamps to opentelemetry-stdout#1391
cijothomas merged 1 commit intoopen-telemetry:mainfrom
SkaillZ:fix-missing-event-timestamp

Conversation

@SkaillZ
Copy link
Contributor

@SkaillZ SkaillZ commented Nov 22, 2023

Fixes #1390

Changes

Adds timestamps to events in opentelemetry-stdout.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@SkaillZ SkaillZ requested a review from a team November 22, 2023 15:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SkaillZ / name: Rene B. (0610412)

@cijothomas
Copy link
Member

thanks for the PR! Could you go through the easycla process and get it cleared, as it is a mandatory prerequisite for accepting contributions! If you are working on behalf of a company, may be good idea to consult legal team as well.

@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3939ab5) 57.2% compared to head (0610412) 57.3%.

Files Patch % Lines
opentelemetry-stdout/src/trace/transform.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1391   +/-   ##
=====================================
  Coverage   57.2%   57.3%           
=====================================
  Files        146     146           
  Lines      18126   18128    +2     
=====================================
+ Hits       10372   10390   +18     
+ Misses      7754    7738   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkaillZ
Copy link
Contributor Author

SkaillZ commented Nov 22, 2023

@cijothomas I've signed it.

@cijothomas cijothomas merged commit 3229979 into open-telemetry:main Nov 22, 2023
@cijothomas
Copy link
Member

@cijothomas I've signed it.

Thank you!

takumi-earth pushed a commit to earthlings-dev/opentelemetry-rust that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Timestamp missing on events exported by opentelemetry-stdout

5 participants