Replace global::shutdown_tracer_provider with tracer_provider.shutdown()#155
Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom Jan 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=====================================
Coverage 54.1% 54.1%
=====================================
Files 42 42
Lines 6279 6282 +3
=====================================
+ Hits 3397 3400 +3
Misses 2882 2882 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jan 22, 2025
| let tracer = provider.tracer_with_scope(scope); | ||
| let _ = global::set_tracer_provider(provider); | ||
| Ok(tracer) | ||
| let _ = global::set_tracer_provider(provider.clone()); |
Member
There was a problem hiding this comment.
OTLP got rid of setting global here, and made it an explicit action user take separately, outside of install_simple/batch. Not a blocker for the PR, just something to consider in future.
cijothomas
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes