metrics: Remove LabelSet #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove LabelSet according to OTEP 90: https://github.com/open-telemetry/oteps/blob/master/text/0090-remove-labelset-from-metrics-api.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 89.56% 89.47% -0.09%
==========================================
Files 43 43
Lines 2213 2195 -18
Branches 249 247 -2
==========================================
- Hits 1982 1964 -18
Misses 159 159
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ocelotl
approved these changes
Mar 25, 2020
...opentelemetry-ext-otcollector/src/opentelemetry/ext/otcollector/metrics_exporter/__init__.py
Show resolved
Hide resolved
Comment on lines
252
to
253
| labels = {"key": "value"} | ||
| key_labels = tuple(sorted(labels.items())) |
There was a problem hiding this comment.
These lines can be moved outside of the for loop.
There was a problem hiding this comment.
Right, moved outside.
lzchen
reviewed
Mar 26, 2020
lzchen
reviewed
Mar 26, 2020
lzchen
reviewed
Mar 26, 2020
lzchen
reviewed
Mar 26, 2020
lzchen
reviewed
Mar 26, 2020
lzchen
reviewed
Mar 26, 2020
| @@ -70,13 +70,13 @@ | |||
| # is essentially metric data that corresponds to a specific set of labels. | |||
| # Therefore, getting a bound metric instrument using the same set of labels | |||
| # will yield the same bound metric instrument. | |||
| bound_requests_counter = requests_counter.bind(label_set) | |||
| bound_requests_counter = requests_counter.bind(labels) | |||
| bound_requests_counter.add(100) | |||
| time.sleep(5) | |||
|
|
|||
| print("Updating using batch calling convention...") | |||
| # You can record metrics in a batch by passing in a labelset and a sequence of | |||
| # (metric, value) pairs. The value would be recorded for each metric using the | |||
| # specified labelset for each. | |||
There was a problem hiding this comment.
Suggested change
| # specified labelset for each. | |
| # specified labels for each. |
Co-Authored-By: Leighton Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove LabelSet according to OTEP 90:
https://github.com/open-telemetry/oteps/blob/master/text/0090-remove-labelset-from-metrics-api.md
Fixes #518.