Skip to content

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented Apr 2, 2025

Description

Fixes #4467 - replace deprecated package with PEP702 warning.deprecated. See description in issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@dimastbk dimastbk marked this pull request as ready for review April 2, 2025 12:45
@dimastbk dimastbk requested a review from a team as a code owner April 2, 2025 12:45
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work on this topic. Do you have any idea of how much size we are reducing here?

Also, should we bump typing-extensions in SDK as well?

@dimastbk
Copy link
Contributor Author

dimastbk commented Apr 9, 2025

Do you have any idea of how much size we are reducing here?

If you asked about the size of dependencies I think not too much, because wrapt is used in many contrib modules, and deprecated is the singlefile module. In my opinion, the main cons for using PEP702 is part of stdlib since Python 3.13 and better supported in IDEs.

Also, should we bump typing-extensions in SDK as well?

Bumped.

@dimastbk dimastbk requested review from emdneto and xrmx April 14, 2025 05:23
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Apr 14, 2025
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the conflicts?

@emdneto emdneto moved this from Ready for review to Approved PRs in @xrmx's Python PR digest May 14, 2025
@emdneto emdneto moved this from Approved PRs to Reviewed PR that needs fixing in @xrmx's Python PR digest May 14, 2025
@dimastbk
Copy link
Contributor Author

All fixed.

@xrmx xrmx moved this from Reviewed PR that needs fixing to Ready for review in @xrmx's Python PR digest May 19, 2025
@lzchen lzchen merged commit c9ad4bc into open-telemetry:main May 21, 2025
384 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in @xrmx's Python PR digest May 21, 2025
@dimastbk dimastbk deleted the issue4467 branch May 22, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace deprecated package with warnings/typing_extensions deprecated
5 participants