prometheus-exporter: fix labels out of place for data points with different attribute sets #4413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
emdneto
force-pushed
the
fix/prom-exporter-labels
branch
from
5e373a1 to
a50e0d1
Compare
nicolastakashi
approved these changes
Feb 18, 2025
xrmx
approved these changes
Feb 18, 2025
tammy-baylis-swi
approved these changes
Feb 27, 2025
aabmass
reviewed
Feb 27, 2025
exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py
Show resolved
Hide resolved
github-project-automation
bot
moved this from Ready for review
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4418
Fixes #3391
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: