Make entry_points behave the same across Python versions #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ocelotl wants to merge 11 commits into open-telemetry:main from ocelotl:issue_3167

Contributor

ocelotl commented Feb 8, 2023

Fixes #3167

ocelotl added the Skip Changelog label

ocelotl self-assigned this

ocelotl requested a review from a team

February 8, 2023 01:21

shalevr reviewed

View reviewed changes

opentelemetry-api/tests/util/test__importlib_metadata.py Show resolved Hide resolved

shalevr reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

shalevr reviewed

View reviewed changes

opentelemetry-api/tests/util/test__importlib_metadata.py Outdated Show resolved Hide resolved

ocelotl force-pushed the issue_3167 branch from 8475312 to bebf212 Compare

February 9, 2023 02:07

ocelotl requested a review from shalevr

February 9, 2023 04:07

ocelotl mentioned this pull request

python configuration prototype MrAlias/otel-schema#44

Closed

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

Contributor

lzchen commented Feb 23, 2023

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

Contributor Author

ocelotl commented Feb 24, 2023

I'm still not sure about the purpose of this change. Could you be more specific about the issue description or provide an example?

@lzchen PTAL here.

ocelotl force-pushed the issue_3167 branch from fc343e7 to f8ac076 Compare

February 24, 2023 23:48

ocelotl mentioned this pull request

Incorporate resource detectors to auto instrumentation #3181

Merged

ocelotl requested a review from lzchen

February 24, 2023 23:53

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/tests/util/test__importlib_metadata.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/tests/util/test__importlib_metadata.py Show resolved Hide resolved

lzchen reviewed

View reviewed changes

opentelemetry-api/tests/util/test__importlib_metadata.py Show resolved Hide resolved

ocelotl requested a review from lzchen

February 28, 2023 17:20

lzchen approved these changes

View reviewed changes

aabmass reviewed

View reviewed changes

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Outdated Show resolved Hide resolved

ocelotl force-pushed the issue_3167 branch 2 times, most recently from 001a70d to f3839c9 Compare

March 13, 2023 23:22

ocelotl added 9 commits

March 13, 2023 17:23


          Make entry_points behave the same across Python versions

c8b1590

Fixes open-telemetry#3167


          Refactor function


          Fix mypy

21bafbb


          Remove braces

9925d89


          Add types

4c09129


          Add group and name tests


          Define __all__ only once

efcea04


          Move the cached dictionary to 3.7 section

653bd1a


          Fix mypy issues

20016f3

ocelotl force-pushed the issue_3167 branch from f3839c9 to 20016f3 Compare

March 13, 2023 23:23

ocelotl requested a review from aabmass

March 13, 2023 23:24

ocelotl mentioned this pull request

refactor code to accomodate Nuitka compilation to C++ code #3154

Closed

7 tasks

ocelotl and others added 2 commits

March 13, 2023 18:46


          Fix lint

61334e7


          Merge branch 'main' into issue_3167

04cc117

Contributor Author

ocelotl commented Mar 14, 2023

May be overridden by #3217.

lzchen mentioned this pull request

Use importlib-metadata regardless of Python version #3217

Merged

Contributor Author

ocelotl commented Mar 16, 2023

Closing in favor of #3217

ocelotl closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels