Skip to content

Django's http_server_active_requests guage has wrong description #2513

Open
@dkliban

Description

@dkliban

I am seeing the following error in my collector when prometheus retrieves /metrics API:

net/http/server.go:2039
2024-05-10T00:53:49.988Z error [email protected]/log.go:23 error gathering metrics: 16 error(s) occurred:
* collected metric pulp_http_server_active_requests label:{name:"http_flavor" value:"1.1"} label:{name:"http_host" value:"pulp-api-svc.pulp-stage.svc.cluster.local:24817"} label:{name:"http_method" value:"PATCH"} label:{name:"http_scheme" value:"http"} label:{name:"http_server_name" value:"::"} label:{name:"job" value:"pulp-api"} gauge:{value:0} has help "measures the number of concurrent HTTP requests that are currently in-flight" but should have "measures the number of concurrent HTTP requests those are currently in flight"
* collected metric pulp_http_server_active_requests label:{name:"http_flavor" value:"1.1"} label:{name:"http_host" value:"10.129.2.18:24817"} label:{name:"http_method" value:"GET"} label:{name:"http_scheme" value:"http"} label:{name:"http_server_name" value:"::"} label:{name:"job" value:"pulp-api"} gauge:{value:0} has help "measures the number of concurrent HTTP requests that are currently in-flight" but should have "measures the number of concurrent HTTP requests those are currently in flight"

I believe the help text here[0] and here[1] needs to be updated to match the rest of the MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS instruments[2].

[0]

description="measures the number of concurrent HTTP requests those are currently in flight",

[1]
description="measures the number of concurrent HTTP requests those are currently in flight",

[2]

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions