-
Notifications
You must be signed in to change notification settings - Fork 577
Add TrafficDistribution support for Collector and TargetAllocator Services #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TrafficDistribution support for Collector and TargetAllocator Services #4301
Conversation
|
@andrefrco you can add this to one of the existing E2E tests, it doesn't merit its own full tests. Could you also rebase on main and run |
|
@andrefrco the e2e test fails on K8s 1.25, which I suspect means that TrafficDistribution isn't supported on that version. You'll need to check the K8s version in the test to account for this. This is done in a few other E2E tests, if you're not sure how to do it in chainsaw. |
9ef1428 to
ab87977
Compare
643bc55 to
1e3b3c3
Compare
…TargetAllocator Services Add TrafficDistribution field to OpenTelemetryCommonFields which is inherited by OpenTelemetryCollector and TargetAllocator. This field allows setting the traffic distribution policy for Kubernetes Services created by these resources. Signed-off-by: andrefrco <[email protected]>
1e3b3c3 to
a394a0e
Compare
I've updated the test to conditionally check TrafficDistribution based on k8s version. Should be good to go now, thanks for your patience. Quick question: we don't need to check if the field exists in the k8s version, do we? It just gets ignored if it's not supported. |
swiatekm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @andrefrco if you can regenerate the manifests again by running make update, we should be good to merge.
Description:
Add TrafficDistribution field to OpenTelemetryCommonFields which is inherited by OpenTelemetryCollector and TargetAllocator. This field allows setting the traffic distribution policy for Kubernetes Services created by these resources.
Link to tracking Issue(s):
Testing:
Documentation: