-
Notifications
You must be signed in to change notification settings - Fork 577
[chore] Add extra labels to spec observability metrics #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add extra labels to spec observability metrics #4174
Conversation
iblancasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add:
- a changelog
- improve the e2e test to check this new feature
a9a621b to
cd9ae41
Compare
3022ccc to
5ac32a6
Compare
|
@iblancasa could you please cross-check #4184? ✓ internal/instrumentation (21.838s)
✓ internal/controllers (40.73s)
=== Skipped
=== SKIP: internal/controllers TestRegisterWithManager_OpAMPBridge (0.00s)
opampbridge_controller_test.go:159: this test requires a real cluster, otherwise the GetConfigOrDie will die
=== SKIP: internal/controllers TestRegisterWithManager (0.00s)
reconcile_test.go:1188: this test requires a real cluster, otherwise the GetConfigOrDie will die
DONE 1795 tests, 2 skipped in 55.687s |
|
@Horiodino rebasing on |
39181b7 to
901a40d
Compare
d3d9c67 to
a4aa808
Compare
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
a4aa808 to
ce341ea
Compare
The objections have been addressed, and the reviewer is currently unavailable. Dismissing to avoid blocking the PR unnecessarily.
Signed-off-by: Praful Khanduri <[email protected]>
ce341ea to
c44c817
Compare
|
Thank you for the contribution and patience with the review process, @Horiodino! |
|
Will this change be bundled into the next stable release? Any expected date for the launch? |
Description:
Added support for
extraLabelsinspec.observability.metricsto allow users to attach additional labels to the generated ServiceMonitor.Fixes: #4138 (comment)
Link to tracking Issue(s):
extraLabelstospec.observability.metrics#4138Testing:
extraLabelsextraLabelsmap containing multiple labelsDocumentation:
extraLabelsfield underspec.observability.metrics.