Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 23, 2025

Which problem is this PR solving?

As far as I can tell, BaggageImpl.prototype.getAllEntries() contains an extraneous call to map() since the array would contain the same values pre- and post-map.

Fixes # N/A

Short description of the changes

This commit removes the extra map() call.

Type of change

None of these. Performance enhancement.

How Has This Been Tested?

  • Test suite

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner December 23, 2025 22:29
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (9a55716) to head (39dc5fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6251   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         314      314           
  Lines        9516     9516           
  Branches     2198     2198           
=======================================
  Hits         9078     9078           
  Misses        438      438           
Files with missing lines Coverage Δ
api/src/baggage/internal/baggage-impl.ts 96.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants