refactor(instrumentation-fetch): replace instanceof Request checks
#6250
+86
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Our team is using DataDome for bot detection. They have set us up with a custom Captcha script which overrides the global Request constructor. We're going to see if they can eliminate this code smell, but in the case where they can't, I believe it would be valuable to improve the Request detection with this duck-typing helper instead. This will prevent requests to incorrect URLs when a patched request instance is provided to
fetch().Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
rpm run testChecklist: