Skip to content

refactor(otlp-exporter-base): simplify isExportHTTPErrorRetryable() #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-luna merged 2 commits into from
Dec 23, 2025
+7 −2
Merged

refactor(otlp-exporter-base): simplify isExportHTTPErrorRetryable() #6249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f8e2a6
refactor(otlp-exporter-base): simplify isExportHTTPErrorRetryable()
cjihrig Dec 22, 2025
ec76320
Apply suggestion from @cjihrig
cjihrig Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
* refactor(instrumentation-http): refactor getIncomingRequestAttributes() to reduce work [#6207](https://github.com/open-telemetry/opentelemetry-js/pull/6207) @cjihrig
* refactor(api-logs,instrumentation-fetch): remove platform-specific globalThis, use globalThis directly [#6208](https://github.com/open-telemetry/opentelemetry-js/pull/6208) @overbalance
* test(otlp-transformer): remove obsolete compat code from toBase64() [#6242](https://github.com/open-telemetry/opentelemetry-js/pull/6242) @cjihrig
* refactor(otlp-exporter-base): simplify isExportHTTPErrorRetryable() [#6249](https://github.com/open-telemetry/opentelemetry-js/pull/6249) @cjihrig

## 0.208.0

Expand Down
8 changes: 6 additions & 2 deletions experimental/packages/otlp-exporter-base/src/is-export-retryable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@
*/

export function isExportHTTPErrorRetryable(statusCode: number): boolean {
const retryCodes = [429, 502, 503, 504];
return retryCodes.includes(statusCode);
return (
statusCode === 429 ||
statusCode === 502 ||
statusCode === 503 ||
statusCode === 504
);
}

export function parseRetryAfterToMills(
Expand Down