Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 19, 2025

Which problem is this PR solving?

The toBase64() test helper function contains compatibility code so that it can work in both Node.js and the browser. However, btoa() has been in Node.js since v16.0.0, which went EOL several years ago, so the Node code is dead code.

Fixes # N/A

Short description of the changes

This commit removes the obsolete and dead code from toBase64().

Type of change

Test refactor

How Has This Been Tested?

  • Test suite

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner December 19, 2025 22:19
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (93d578a) to head (04411ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6242   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         314      314           
  Lines        9513     9513           
  Branches     2194     2194           
=======================================
  Hits         9075     9075           
  Misses        438      438           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-luna david-luna added this pull request to the merge queue Dec 22, 2025
Merged via the queue into open-telemetry:main with commit 1d322bd Dec 22, 2025
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Dec 22, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the tobase64 branch December 22, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants