refactor: expoBuckets uses a circular buffer to avoid shifts #7706
+229
−247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7535
We currently prepend or append new elements to the counts slice when we get an observation outside of the current buckets. This can't be done in a lockless way.
This PR refactors the expo buckets to instead use a fixed-size pre-allocated slice, and separately track the start and end of the actual slice. For bin i, the getIdx function always returns the same value, so shifting elements within the slice is never required. The only time we will need exclusive access is if we need to downscale.
The downside is that we always allocate the full maxSize number of buckets for positive and negative, even if there are no negative observations. We might be able to lazily initialize the buckets to fix this as a follow-up.
Not much of a performance impact:
The alternative is that we need to lock whenever we resize the bucket array instead of only when we need to downscale.