-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed as not planned
Labels
invalidThis doesn't seem rightThis doesn't seem rightpkg:exporter:prometheusRelated to the Prometheus exporter packageRelated to the Prometheus exporter package
Milestone
Description
The resolution to #7066 causes the Prometheus handler to fail on invalid metrics. By default we do not convert things like ""go_gc_duration_seconds" (type summary) which the Prometheus HTTP handler adds by default.
This means that by default now our exporter fails the HTTP handler with a 500 for the invalid metric.
Users need to explicitly disable this failure mode to use the exporter given we do not support these types and they cannot fix the error.
How to reproduce
Run the TestMetricProducerPrometheusWithPrometheusExporter test for the v1.38.0 release of that module using the latest release of the prometheus exporter (v1.39.0). It now fails by default complaining there is an invalid metric type for at least the mentioned "go_gc_duration_seconds".
Metadata
Metadata
Assignees
Labels
invalidThis doesn't seem rightThis doesn't seem rightpkg:exporter:prometheusRelated to the Prometheus exporter packageRelated to the Prometheus exporter package
Type
Projects
Status
Closed