Skip to content

Conversation

@martincostello
Copy link
Member

Changes

Remove workaround for dotnet/sdk#51265 that should be fixed in the stable .NET 10 SDK that was missed from #6667.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Removed workaround for package pruning issue that should be fixed in the stable .NET 10 SDK.
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (6648ff3) to head (cadc1ba).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6767      +/-   ##
==========================================
- Coverage   86.74%   86.72%   -0.02%     
==========================================
  Files         262      262              
  Lines       12319    12319              
==========================================
- Hits        10686    10684       -2     
- Misses       1633     1635       +2     
Flag Coverage Δ
unittests-Project-Experimental 86.60% <ø> (+<0.01%) ⬆️
unittests-Project-Stable 86.57% <ø> (-0.13%) ⬇️
unittests-Solution 86.66% <ø> (-0.04%) ⬇️
unittests-UnstableCoreLibraries-Experimental 86.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@martincostello martincostello marked this pull request as ready for review December 12, 2025 14:18
@martincostello martincostello requested a review from a team as a code owner December 12, 2025 14:18
Copilot AI review requested due to automatic review settings December 12, 2025 14:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a workaround for a .NET SDK issue (dotnet/sdk#51265) that has been resolved in the stable .NET 10 SDK. The workaround was originally implemented to handle package pruning problems but is no longer necessary.

Key changes:

  • Removed the RestoreEnablePackagePruning property workaround from the root build configuration
  • Updated the Coyote test dependency approach to suppress security advisories instead of using direct package version overrides, avoiding NU1510 warnings in .NET 10 SDK

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Build.props Removed the RestoreEnablePackagePruning workaround property that was addressing SDK issue #51265
test/Directory.Build.targets Replaced System.Text.Json VersionOverride with NuGetAuditSuppress entries for security advisories to avoid .NET 10 SDK NU1510 warnings while still addressing the vulnerabilities

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rajkumar-rangaraj rajkumar-rangaraj added this pull request to the merge queue Dec 12, 2025
Merged via the queue into open-telemetry:main with commit 488f62d Dec 12, 2025
91 checks passed
@martincostello martincostello deleted the remove-workaround branch December 12, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants