Skip to content

Conversation

@martincostello
Copy link
Member

Changes

The referenced issue isn't fixed in .NET 9 or 10. Update the comment to not reference a specific version.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

The referenced issue isn't fixed in .NET 9 or 10. Update the comment to not reference a specific version.
Copilot AI review requested due to automatic review settings December 12, 2025 12:05
@martincostello martincostello requested a review from a team as a code owner December 12, 2025 12:05
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Dec 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a comment in the OTLP exporter project file to remove references to a specific .NET version (.NET 9), since the referenced issue was not fixed in .NET 9 or 10. The comment now refers to a future .NET release generically, making it version-agnostic and more accurate.

  • Updated comment to replace "(hopefully .NET 9)" with "in a future release of .NET"
  • Improved XML comment formatting and indentation for better readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.75%. Comparing base (3202b94) to head (523ae63).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6766      +/-   ##
==========================================
- Coverage   86.76%   86.75%   -0.01%     
==========================================
  Files         262      262              
  Lines       12319    12319              
==========================================
- Hits        10688    10687       -1     
- Misses       1631     1632       +1     
Flag Coverage Δ
unittests-Project-Experimental 86.59% <ø> (-0.08%) ⬇️
unittests-Project-Stable 86.36% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@Kielek Kielek enabled auto-merge December 12, 2025 12:15
@Kielek Kielek added this pull request to the merge queue Dec 12, 2025
Merged via the queue into open-telemetry:main with commit 6648ff3 Dec 12, 2025
60 checks passed
@martincostello martincostello deleted the update-comment branch December 12, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants