[Exporter.Zipkin] Unskip ErrorGettingUriFromEnvVarSetsDefaultEndpointValue test#6184
Merged
rajkumar-rangaraj merged 4 commits intoopen-telemetry:mainfrom Mar 13, 2025
Conversation
github-actions
bot
added
the
pkg:OpenTelemetry.Exporter.Zipkin
…efaultEndpointValue
rajkumar-rangaraj
approved these changes
Mar 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6184 +/- ##
==========================================
+ Coverage 86.21% 86.27% +0.06%
==========================================
Files 259 259
Lines 11770 11771 +1
==========================================
+ Hits 10147 10156 +9
+ Misses 1623 1615 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
TimothyMothra
approved these changes
Mar 13, 2025
TimothyMothra
left a comment
TimothyMothra
left a comment
There was a problem hiding this comment.
easiest review I've done all week :)
…efaultEndpointValue
…efaultEndpointValue
Kielek
deleted the
zipkin-unskip-ErrorGettingUriFromEnvVarSetsDefaultEndpointValue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3690 was fixed in scope of #4095
Changes
[Exporter.Zipkin] Unskip ErrorGettingUriFromEnvVarSetsDefaultEndpointValue test
Merge requirement checklist
[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)