[prometheus] Support meter-level tags#5837
Merged
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom Sep 23, 2024
robertcoltheart:main
Merged
[prometheus] Support meter-level tags#5837CodeBlanch merged 5 commits intoopen-telemetry:mainfrom robertcoltheart:main
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom
robertcoltheart:main
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5837 +/- ##
==========================================
+ Coverage 83.38% 86.30% +2.91%
==========================================
Files 297 257 -40
Lines 12531 11172 -1359
==========================================
- Hits 10449 9642 -807
+ Misses 2082 1530 -552
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Sep 16, 2024
cijothomas
reviewed
Sep 16, 2024
| buffer[cursor++] = unchecked((byte)','); | ||
| } | ||
|
|
||
| if (metric.MeterTags != null) |
Member
There was a problem hiding this comment.
I see that the current tests have been updated to validate MeterTags. Is there a test that validates null MeterTags?"
reyang
approved these changes
Sep 20, 2024
Contributor
Author
|
I've added some additional tests as requested. I think a follow-up PR is required to refactor these tests a bit, since we have quite a few different combinations of conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
#5836
Changes
Adds meter-level tags to Prometheus exporter. Any tags added to meter are automatically added to scrape output.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes