You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: At the moment everything on Exemplar has a private setter and the Update method is internal so there isn't really a good practical way to make a custom ExemplarReservoir. I'm going to tackle that as a follow-up because there are different approaches we could take.
Merge requirement checklist
CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
Appropriate CHANGELOG.md files updated for non-trivial changes
Is Exemplar stable release planned for 1.9.0 ? if yes, can we just expose this unconditionally? Or are you anticipating that 1.9.0 stable won't have stable exemplars, and hence this PR?
Is Exemplar stable release planned for 1.9.0 ? if yes, can we just expose this unconditionally? Or are you anticipating that 1.9.0 stable won't have stable exemplars, and hence this PR?
Yes it is planned for 1.9.0. I don't think we're ready to remove experimental status yet though. I want to finish implementing the spec and wait for it go stable before we do that. Probably just a final PR at the end of the effort which makes the switch for everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ExemplarReservoirin pre-release builds.MetricStreamConfiguration.ExemplarReservoirFactoryin pre-release builds.Details
This is being done to be complaint with the view configuration spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#stream-configuration
Note: At the moment everything on
Exemplarhas aprivatesetter and the Update method isinternalso there isn't really a good practical way to make a customExemplarReservoir. I'm going to tackle that as a follow-up because there are different approaches we could take.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes