[Instrumentation.SqlClient] Stop emitting db.statement_type attribute#5301
Merged
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom Feb 5, 2024
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5301 +/- ##
==========================================
- Coverage 83.38% 83.06% -0.32%
==========================================
Files 297 272 -25
Lines 12531 11971 -560
==========================================
- Hits 10449 9944 -505
+ Misses 2082 2027 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
cijothomas
approved these changes
Feb 1, 2024
rajkumar-rangaraj
approved these changes
Feb 1, 2024
vishweshbankwar
approved these changes
Feb 1, 2024
This was referenced Oct 11, 2025
Closed
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
[Instrumentation.SqlClient] Stop emitting
db.statement_typeattribute.It was introduced in https://github.com/open-telemetry/opentelemetry-dotnet/pull/761/files#r450626620. It is not part of semantic convention. I didn't find any other occurrence for this except open-telemetry/opentelemetry-dotnet-contrib#1559
As a separate work, we should consider adding
db.operation/sanitizingdb.statement.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)N/A