Scope info should only be exported for Prometheus if OpenMetrics is requested#5182
Merged
utpilla merged 5 commits intoopen-telemetry:mainfrom Dec 15, 2023
robertcoltheart:bug/fix-export-scope-info
Merged
Scope info should only be exported for Prometheus if OpenMetrics is requested#5182utpilla merged 5 commits intoopen-telemetry:mainfrom robertcoltheart:bug/fix-export-scope-info
utpilla merged 5 commits intoopen-telemetry:mainfrom
robertcoltheart:bug/fix-export-scope-info
Conversation
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5182 +/- ##
==========================================
- Coverage 83.50% 83.48% -0.03%
==========================================
Files 297 297
Lines 12386 12387 +1
==========================================
- Hits 10343 10341 -2
- Misses 2043 2046 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reyang
approved these changes
Dec 15, 2023
Member
reyang
left a comment
There was a problem hiding this comment.
Consider updating the changelog by putting this PR and the previous PR under the same entry (similar to what https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#050-beta2 has - "Refactored simple export and batch export APIs (#1078 #1081 #1083 #1085 #1087 #1094 #1113 #1127 #1129 #1135)").
utpilla
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3972
Changes
otel_scope_infowas mistakenly being exported for non-OpenMetrics scrapes. This fix corrects this so that it will only be exposed for OpenMetrics.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes