Add metric bucket override for OpenTelemetry.Instrumentation.AspNet#5063
Merged
utpilla merged 3 commits intoopen-telemetry:mainfrom Nov 20, 2023
Merged
Add metric bucket override for OpenTelemetry.Instrumentation.AspNet#5063utpilla merged 3 commits intoopen-telemetry:mainfrom
utpilla merged 3 commits intoopen-telemetry:mainfrom
Conversation
4 tasks
cijothomas
reviewed
Nov 18, 2023
cijothomas
approved these changes
Nov 18, 2023
Member
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
Nit suggestion on better changelog wording.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5063 +/- ##
==========================================
- Coverage 83.69% 83.66% -0.04%
==========================================
Files 296 296
Lines 12484 12485 +1
==========================================
- Hits 10449 10446 -3
- Misses 2035 2039 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Nov 20, 2023
vishweshbankwar
approved these changes
Nov 20, 2023
utpilla
approved these changes
Nov 20, 2023
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in a PR from the opentelemetry-dotnet-contrib project.
Without this change any user of
OpenTelemetry.Instrumentation.AspNetwould have to explicitly add a view.Changes
Updates
DefaultHistogramBoundShortMappingsto include an override forOpenTelemetry.Instrumentation.AspNet(http.request.server.duration).Created this PR since @cijothomas suggested this here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes