Make MetricPoint reclaim an opt-in experimental feature#5052
Conversation
utpilla
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5052 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.02%
==========================================
Files 296 296
Lines 12481 12479 -2
==========================================
- Hits 10427 10424 -3
- Misses 2054 2055 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vishweshbankwar
left a comment
vishweshbankwar
left a comment
There was a problem hiding this comment.
LGTM - We should document the experimental features here
| [InlineData("FALSE", false)] | ||
| [InlineData("true", true)] | ||
| [InlineData("True", true)] | ||
| [InlineData("TRUE", true)] |
| using var meterProvider = Sdk.CreateMeterProviderBuilder() | ||
| .ConfigureServices(services => | ||
| { | ||
| services.AddSingleton(this.configuration); | ||
| }) | ||
| .AddMeter(meter.Name) | ||
| .AddInMemoryExporter(exportedItems) |
There was a problem hiding this comment.
No biggie if you don't want to do take this on, but seems like these lines are repeated a bajillion times in this file. Might be a good extract method opportunity.
There was a problem hiding this comment.
Bajillion is an informal word that means a very large but unspecified number. It is not a real number, but a way of exaggerating or expressing a huge quantity. For example, one might say “I have a bajillion things to do today” to mean that they have a lot of tasks. The word bajillion is probably a blend of bazillion and jillion, which are also informal words for a large number12. There is no standard way to write bajillion in numerals, since it is not a precise value. However, some people might use a 1 followed by many zeros, such as 1,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000, or use scientific notation, such as 10100
or 10googol
, where googol is another name for 10100
. However, these are just arbitrary representations, and there is no official or correct way to write bajillion.
Learned something new today!
There was a problem hiding this comment.
@utpilla Don't worry about refactoring it on here. On #4958 I'm refactoring how these tests create their providers. Example: https://github.com/open-telemetry/opentelemetry-dotnet/pull/4958/files#diff-ae011cf18b74623dd9376d03c8629da33ab122c4d4b6a6c9d3f54325a13637eeR44
I'll have to merge these changes over there and I can encapsulate the config into the helper to achieve what @alanwest is asking for.
There was a problem hiding this comment.
1,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000
Ok, I'll admit I exaggerated a bit... This prolly woulda broken GitHub.
|
Related to #2360 |
5 participants
Related to #4486
Changes
OTEL_DOTNET_EXPERIMENTAL_METRICS_RECLAIM_UNUSED_METRIC_POINTSMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes