Remove zero bucket for the histogram buckets for ASP.NET Core and HttpClient metrics#5021
Conversation
src/OpenTelemetry/CHANGELOG.md
Outdated
| 5, 10, 30, 60, 120, 300 ]`. | ||
| ([#5008](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5008)) | ||
|
|
||
| * Remove the bucket with value `0` for histogram buckets for metrics from |
There was a problem hiding this comment.
do we really need this entry as the above entry already shows the buckets without 0?
There was a problem hiding this comment.
The PR associated with the above entry adds the zero bucket
This PR removes the zero bucket for the previously added metrics as well. I thought it's better to just list out the correct buckets even for the above entry.
Codecov Report
@@ Coverage Diff @@
## main #5021 +/- ##
==========================================
+ Coverage 83.38% 83.43% +0.05%
==========================================
Files 296 296
Lines 12385 12385
==========================================
+ Hits 10327 10334 +7
+ Misses 2058 2051 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #4908
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes