Fix Prometheus exporter writing bool label values#4823
Merged
utpilla merged 7 commits intoopen-telemetry:mainfrom Sep 7, 2023
Merged
Fix Prometheus exporter writing bool label values#4823utpilla merged 7 commits intoopen-telemetry:mainfrom
utpilla merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4823 +/- ##
==========================================
+ Coverage 83.90% 83.91% +0.01%
==========================================
Files 293 293
Lines 11998 12001 +3
==========================================
+ Hits 10067 10071 +4
+ Misses 1931 1930 -1
|
reyang
approved these changes
Sep 5, 2023
reyang
reviewed
Sep 5, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs
Show resolved
Hide resolved
JamesNK
commented
Sep 6, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs
Show resolved
Hide resolved
cijothomas
approved these changes
Sep 6, 2023
rajkumar-rangaraj
approved these changes
Sep 6, 2023
Kielek
approved these changes
Sep 6, 2023
Contributor
Author
|
Done |
6 tasks
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4822
Design discussion issue #
Changes
Prometheus exporter writes bool label values as lowercase
trueandfalsestrings.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes