Set Activity.Status when adding SetErrorStatusOnException#4336
Set Activity.Status when adding SetErrorStatusOnException#4336cijothomas merged 9 commits intoopen-telemetry:mainfrom
Conversation
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
Not clear how the linked issue is addressed with this PR. The linked issue can be fixed by setting status on Activity (w/o using tags)
vishweshbankwar
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4336 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 298 298
Lines 11983 11984 +1
=======================================
+ Hits 10152 10153 +1
Misses 1831 1831
|
| if (snapshot != pointers) | ||
| { | ||
| // TODO: Remove this when SetStatus is deprecated | ||
| activity.SetStatus(Status.Error); |
There was a problem hiding this comment.
I assume there's never a time we'd call this version of SetStatus and not also want to call the "real" version, right?
Here's another spot
We could kill two stones with one bird if we moved the call to activity.SetStatus(ActivityStatusCode) to our extension method. Though, from what I can tell I think that OpenTracing shim is the only other place... so maybe easier to just duplicate the call there as well.
There was a problem hiding this comment.
@alanwest I was not aware of this one, will get it updated. what do you think about marking our extension method obsolete?
There was a problem hiding this comment.
I would support marking it obsolete.
4 participants
Fixes #4333
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes