[sdk] Remove System.Reflection.Emit.Lightweight dependency#4140
Merged
CodeBlanch merged 4 commits intoopen-telemetry:mainfrom Feb 2, 2023
Merged
[sdk] Remove System.Reflection.Emit.Lightweight dependency#4140CodeBlanch merged 4 commits intoopen-telemetry:mainfrom
CodeBlanch merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4140 +/- ##
==========================================
- Coverage 85.54% 85.48% -0.06%
==========================================
Files 293 293
Lines 11371 11371
==========================================
- Hits 9727 9721 -6
- Misses 1644 1650 +6
|
reyang
approved these changes
Feb 2, 2023
Kielek
approved these changes
Feb 2, 2023
Member
Kielek
left a comment
There was a problem hiding this comment.
Consider to put information about direct dependency i OTLP CHANGELOG (I know that it was transitively available).
CodeBlanch
commented
Feb 2, 2023
| <PackageReference Include="Grpc" Version="$(GrpcPkgVer)" Condition="'$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'net462'" /> | ||
| <PackageReference Include="Google.Protobuf" Version="$(GoogleProtobufPkgVer)" /> | ||
| <PackageReference Include="Grpc.Tools" Version="$(GrpcToolsPkgVer)" PrivateAssets="all" /> | ||
| <PackageReference Include="System.Reflection.Emit.Lightweight" Version="$(SystemReflectionEmitLightweightPkgVer)" Condition="'$(TargetFramework)' != 'net6.0'" /> |
Member
Author
There was a problem hiding this comment.
For those curious, OTLP Exporter uses a couple dynamic methods to reset the count of RepeatedFields so they may be reused to avoid some allocations. Example here. A while back we were able to get a change put into Protobuf to make the default clear behavior capacity-preserving. I just checked, there is 3.22.0-rc1 which includes the change. So it seems we will be able to clean this up soon!
alanwest
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
System.Reflection.Emit.Lightweightdependency from SDK (it is no longer needed).System.Reflection.Emit.Lightweightdependency toOpenTelemetry.Exporter.OpenTelemetryProtocolwhere it is currently needed.TODOs
CHANGELOG.mdupdated for non-trivial changes