Skip to content

[Traces] Add named options support to ZipkinExporter builder extensions#3655

Merged
CodeBlanch merged 2 commits intoopen-telemetry:mainfrom
CodeBlanch:zipkin-namedoptions
Sep 13, 2022
Merged

[Traces] Add named options support to ZipkinExporter builder extensions#3655
CodeBlanch merged 2 commits intoopen-telemetry:mainfrom
CodeBlanch:zipkin-namedoptions

Conversation

@CodeBlanch
Copy link
Copy Markdown
Member

@CodeBlanch CodeBlanch commented Sep 13, 2022

Changes

Applies the named options pattern from #3648 to ZipkinExporter.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit Tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 13, 2022 21:05
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3655 (13a40da) into main (b4ade26) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3655      +/-   ##
==========================================
+ Coverage   87.76%   87.84%   +0.07%     
==========================================
  Files         283      283              
  Lines       10237    10240       +3     
==========================================
+ Hits         8985     8995      +10     
+ Misses       1252     1245       -7     
Impacted Files Coverage Δ
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 97.77% <100.00%> (+0.15%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-2.23%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 100.00% <0.00%> (+21.05%) ⬆️

@CodeBlanch CodeBlanch merged commit a87f8f7 into open-telemetry:main Sep 13, 2022
@CodeBlanch CodeBlanch deleted the zipkin-namedoptions branch September 13, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants