Skip to content

PrometheusExporter: Return last-modified header on scrape endpoint responses#2613

Merged
cijothomas merged 2 commits intoopen-telemetry:mainfrom
CodeBlanch:prometheus-lastmodified
Nov 16, 2021
Merged

PrometheusExporter: Return last-modified header on scrape endpoint responses#2613
cijothomas merged 2 commits intoopen-telemetry:mainfrom
CodeBlanch:prometheus-lastmodified

Conversation

@CodeBlanch
Copy link
Copy Markdown
Member

Follow-up to: #2610

See: #2610 (comment)

@CodeBlanch CodeBlanch requested a review from a team November 16, 2021 04:19
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2613 (a019db1) into main (f09f62b) will increase coverage by 0.02%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
+ Coverage   80.38%   80.40%   +0.02%     
==========================================
  Files         257      257              
  Lines        8838     8851      +13     
==========================================
+ Hits         7104     7117      +13     
  Misses       1734     1734              
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <95.00%> (+1.39%) ⬆️
...eus/Implementation/PrometheusExporterHttpServer.cs 54.66% <100.00%> (+0.61%) ⬆️
...eus/Implementation/PrometheusExporterMiddleware.cs 62.96% <100.00%> (+1.42%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️

@cijothomas cijothomas merged commit ca20c80 into open-telemetry:main Nov 16, 2021
@CodeBlanch CodeBlanch deleted the prometheus-lastmodified branch November 16, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants