Skip to content

Test improvements#2612

Merged
cijothomas merged 3 commits intoopen-telemetry:mainfrom
reyang:reyang/prometheus-test
Nov 16, 2021
Merged

Test improvements#2612
cijothomas merged 3 commits intoopen-telemetry:mainfrom
reyang:reyang/prometheus-test

Conversation

@reyang
Copy link
Copy Markdown
Member

@reyang reyang commented Nov 16, 2021

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2612 (81e3cbe) into main (e871c27) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
+ Coverage   80.22%   80.38%   +0.15%     
==========================================
  Files         257      257              
  Lines        8844     8838       -6     
==========================================
+ Hits         7095     7104       +9     
+ Misses       1749     1734      -15     
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 80.88% <100.00%> (ø)
...ometheus/Implementation/PrometheusSerializerExt.cs 37.33% <100.00%> (+4.00%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
....Prometheus/Implementation/PrometheusSerializer.cs 72.16% <0.00%> (+9.27%) ⬆️

Copy link
Copy Markdown
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit f09f62b into open-telemetry:main Nov 16, 2021
@reyang reyang deleted the reyang/prometheus-test branch November 16, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants