OTLP exporter: Fix TypeInitializationException thrown by exporter#1873
Merged
cijothomas merged 5 commits intoopen-telemetry:mainfrom Mar 31, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 83.56% 83.56% -0.01%
==========================================
Files 192 192
Lines 6163 6150 -13
==========================================
- Hits 5150 5139 -11
+ Misses 1013 1011 -2
|
Member
Author
|
@CodeBlanch @cijothomas @reyang I fairly certain the increase in memory allocated is not due to the code changes here. The new I suspect that the increase in allocation is related to upgrading our dependency to 3.15. |
reyang
reviewed
Mar 31, 2021
Member
|
LGTM I don't think the change is the reason for the perf hit: That all seems perfectly reasonable to me. Assuming it is flowing through that |
Co-authored-by: Reiley Yang <reyang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1854.
Uses new
UnsafeByteOperations.UnsafeWrapmethod in Google.Protobuf 3.15+ to avoid additionalbyte[]allocation.Perf before:
Perf after:
Seems there is a bit of an increase in memory allocated... I will investigate why.