ParentBasedSampler should not explicitly consider Links#1851
Merged
cijothomas merged 7 commits intoopen-telemetry:mainfrom Mar 6, 2021
Merged
ParentBasedSampler should not explicitly consider Links#1851cijothomas merged 7 commits intoopen-telemetry:mainfrom
cijothomas merged 7 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
Just waiting for the related PR to get merged before making changes to the actual sampler. |
Codecov Report
@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 83.77% 83.29% -0.49%
==========================================
Files 187 189 +2
Lines 5967 6123 +156
==========================================
+ Hits 4999 5100 +101
- Misses 968 1023 +55
|
reyang
reviewed
Feb 27, 2021
cijothomas
approved these changes
Mar 5, 2021
Member
|
@mbakalov thanks! please resolve conflict and we are good to merge. |
Contributor
Author
Thanks @cijothomas - done now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1846.
Changes
Previously we had functionality in
ParentBasedSamplerthat would consider activity links and return RecordAndSample if one of the links was sampled. This isn't according to the spec and is removed in this PR.In a related PR we've added customization capability to
ParentBasedSamplerthat can be used to examine links if needed.CHANGELOG.mdupdated for non-trivial changes