Skip to content

Added Activity.IsRecorded check for Export#1574

Merged
cijothomas merged 6 commits intoopen-telemetry:masterfrom
utpilla:utpilla/Add-IsRecorded-Check-For-Export
Nov 18, 2020
Merged

Added Activity.IsRecorded check for Export#1574
cijothomas merged 6 commits intoopen-telemetry:masterfrom
utpilla:utpilla/Add-IsRecorded-Check-For-Export

Conversation

@utpilla
Copy link
Copy Markdown
Contributor

@utpilla utpilla commented Nov 18, 2020

Fixes #1558

Changes

  • Added a check for ActivityTraceFlags for export

@utpilla utpilla requested a review from a team November 18, 2020 00:40
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1574 (b815f55) into master (9e90fce) will decrease coverage by 0.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   81.51%   80.68%   -0.83%     
==========================================
  Files         237      241       +4     
  Lines        6449     6525      +76     
==========================================
+ Hits         5257     5265       +8     
- Misses       1192     1260      +68     
Impacted Files Coverage Δ
src/OpenTelemetry/BatchExportProcessor.cs 93.05% <ø> (ø)
src/OpenTelemetry/SimpleExportProcessor.cs 70.00% <ø> (ø)
src/OpenTelemetry/BaseExportProcessor.cs 85.71% <100.00%> (+3.36%) ⬆️
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <0.00%> (ø)
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 4.91% <0.00%> (ø)
...lemetry.Exporter.Console/ConsoleExporterOptions.cs 100.00% <0.00%> (ø)
...xporter.Console/ConsoleExporterHelperExtensions.cs 0.00% <0.00%> (ø)

Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit b247b3d into open-telemetry:master Nov 18, 2020
@utpilla utpilla deleted the utpilla/Add-IsRecorded-Check-For-Export branch November 30, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActivityExporter is called even if Activity.Recorded is false.

5 participants