Fixing ActivitySource from DiagnosticSource#1515
Merged
cijothomas merged 9 commits intoopen-telemetry:masterfrom Nov 12, 2020
eddynaka:feature/fixing-instrumentation-diagnosticsource
Merged
Fixing ActivitySource from DiagnosticSource#1515cijothomas merged 9 commits intoopen-telemetry:masterfrom eddynaka:feature/fixing-instrumentation-diagnosticsource
cijothomas merged 9 commits intoopen-telemetry:masterfrom
eddynaka:feature/fixing-instrumentation-diagnosticsource
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
+ Coverage 81.34% 81.40% +0.06%
==========================================
Files 233 233
Lines 6336 6358 +22
==========================================
+ Hits 5154 5176 +22
Misses 1182 1182
|
Contributor
Author
|
Running benchmark, I could not see any difference:
AFTER
|
cijothomas
reviewed
Nov 12, 2020
src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
Member
|
|
…ps://github.com/eddynaka/opentelemetry-dotnet into feature/fixing-instrumentation-diagnosticsource
cijothomas
approved these changes
Nov 12, 2020
cijothomas
reviewed
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1522
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes