Update AddInMemoryExporter extension method signature#1514
Merged
cijothomas merged 11 commits intoopen-telemetry:masterfrom Nov 13, 2020
Merged
Update AddInMemoryExporter extension method signature#1514cijothomas merged 11 commits intoopen-telemetry:masterfrom
cijothomas merged 11 commits intoopen-telemetry:masterfrom
Conversation
alanwest
reviewed
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 81.36% 81.40% +0.04%
==========================================
Files 233 232 -1
Lines 6358 6357 -1
==========================================
+ Hits 5173 5175 +2
+ Misses 1185 1182 -3
|
cijothomas
reviewed
Nov 12, 2020
| var activityExporter = new InMemoryExporter<Activity>(activityList); | ||
|
|
||
| var logRecordList = new List<LogRecord>(); | ||
| var logExporter = new InMemoryExporter<LogRecord>(logRecordList); |
Member
There was a problem hiding this comment.
we need to improve to an full usable example. Lets do it in a separate PR.
cijothomas
approved these changes
Nov 12, 2020
alanwest
approved these changes
Nov 13, 2020
cijothomas
approved these changes
Nov 13, 2020
This was referenced Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes