[SqlClient] Add tags required for sampling before activity start#3675
Conversation
github-actions
bot
added
the
comp:instrumentation.sqlclient
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
==========================================
- Coverage 71.68% 71.45% -0.23%
==========================================
Files 455 455
Lines 17640 17654 +14
==========================================
- Hits 12645 12615 -30
- Misses 4995 5039 +44 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| && (string)kvp.Value == testCase.Expected.DbCollectionName); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(testCase.Expected.DbStoredProcedureName)) |
There was a problem hiding this comment.
Technically, the spec does not require db.stored_procedure.name be available prior to sampling, but it was simpler to just include it with the rest of the attributes.
alanwest
changed the title
I'll look to do a clean-up post-merge. |
224c66b
3 participants
Fixes #2224
@martincostello Oops I think there was a miscommunication. #2224 has not been resolved yet. This PR conforms to the spec by making sure all the attributes that are required for sampling are present when the activity is started.
I did not touch the EFCore instrumentation in this PR. I ended up duplicating some code in
DatabaseSemanticConventionHelperthat could probably be refactored a bit once this is ported to EFCore.