[EFCore] [SqlClient] Remove SetDbQueryParameters#3081
Merged
Kielek merged 5 commits intoopen-telemetry:mainfrom Sep 9, 2025
Merged
[EFCore] [SqlClient] Remove SetDbQueryParameters#3081Kielek merged 5 commits intoopen-telemetry:mainfrom
Kielek merged 5 commits intoopen-telemetry:mainfrom
Conversation
Make the new `SetDbQueryParameters` property internal and gate behind an environment variable instead.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the SetDbQueryParameters property internal and configures it through environment variables instead of exposing it as a public API. The change affects both SqlClient and EntityFrameworkCore instrumentation libraries.
Key changes:
- Made
SetDbQueryParametersproperty internal instead of public - Added environment variable configuration for both libraries
- Updated documentation to remove public API usage examples
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SqlClientTraceInstrumentationOptions.cs | Made SetDbQueryParameters internal and added environment variable configuration |
| EntityFrameworkInstrumentationOptions.cs | Made SetDbQueryParameters internal and added environment variable configuration |
| SqlClient README.md | Removed public API documentation section |
| EntityFrameworkCore README.md | Removed public API documentation section |
| Test files | Added tests for environment variable configuration |
| PublicAPI.Unshipped.txt | Removed public API entries |
| CHANGELOG.md | Updated to reference environment variable instead of public option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/EntityFrameworkInstrumentationOptions.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
==========================================
+ Coverage 69.74% 69.87% +0.12%
==========================================
Files 410 410
Lines 16264 16239 -25
==========================================
+ Hits 11344 11347 +3
+ Misses 4920 4892 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kielek
reviewed
Sep 8, 2025
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Add link to this PR too. Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
matt-hensley
reviewed
Sep 8, 2025
matt-hensley
reviewed
Sep 8, 2025
Restore the original README content for `SetDbQueryParameters` under a new Experimental features heading.
Be consistent with the other notes.
Kielek
approved these changes
Sep 9, 2025
This was referenced Sep 26, 2025
This was referenced Oct 6, 2025
Closed
Closed
This was referenced Nov 3, 2025
Closed
This was referenced Nov 12, 2025
This was referenced Nov 24, 2025
This was referenced Dec 22, 2025
This was referenced Dec 30, 2025
Closed
This was referenced Jan 6, 2026
Closed
This was referenced Jan 13, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3078
Changes
Make the new
SetDbQueryParametersproperty internal and gate behind an environment variable instead.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes