[Instrumentation.AWS] Update to AWSSDK v4#2720
[Instrumentation.AWS] Update to AWSSDK v4#2720rajkumar-rangaraj merged 8 commits intoopen-telemetry:mainfrom
Conversation
test/OpenTelemetry.Instrumentation.AWS.Tests/Implementation/RequestContextHelperTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.AWS.Tests/OpenTelemetry.Instrumentation.AWS.Tests.csproj
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.AWS.Tests/TestAWSClientInstrumentation.cs
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
- Coverage 73.91% 69.51% -4.41%
==========================================
Files 267 394 +127
Lines 9615 15871 +6256
==========================================
+ Hits 7107 11032 +3925
- Misses 2508 4839 +2331 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@martincostello - could you comment on this point I raised about versioning here: #2719 (comment) |
|
@martincostello - this looks good to me! Only concerns are around communicating that bumping the aws sdk v3 to v4 has breaking changes. But from the SIG meeting on April 29, Open Telemetry core is about to do a Minor version release to 1.12. I think it would be nice to get this change in ASAP and then release the AWS Open Telemetry libraries as 1.12.0. This way we have a minor bump -and-continue to track the same version as open telemetry core library. |
|
@ppittle I don't have any particularly strong feelings on the version. I assumed 1.{1 more than the last release}.0 would be the minimum. A full major version feels too much for how the OTel libraries general version themselves. Bundling this with 1.12.x of the core seems reasonable. |
|
UPDATE: Let's merge #2726 first, to better indicate in NuGet the last version that works with AWS SDK v3. @martincostello - If you change the release notes per my comment, I'm good to approve this. We can defer final versioning change until the next release - but I concur either a Major or Minor bump would be appropriate. My current thinking is Minor bump. |
Update OpenTelemetry.Instrumentation.AWS to depend on v4 of the AWS SDK for .NET. Resolves open-telemetry#2719.
Add real pull request number.
Initialize `HttpProtocolVersion`.
Update minimum target for .NET Framework to 4.7.2 as 4.6.2 is not supported, otherwise users get `netstandard2.0` instead.
Implement mock property for `net472`.
Update AWSSDK.DynamoDBv2 to 4.0.0.2 to pick up fix for aws/aws-sdk-net#3776.
Fixes #2719
Changes
Update OpenTelemetry.Instrumentation.AWS to depend on v4 of the AWS SDK for .NET.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes