Skip to content

[Instrumentation.AWS] Update to AWSSDK v4#2720

Merged
rajkumar-rangaraj merged 8 commits intoopen-telemetry:mainfrom
martincostello:gh-2719
May 2, 2025
Merged

[Instrumentation.AWS] Update to AWSSDK v4#2720
rajkumar-rangaraj merged 8 commits intoopen-telemetry:mainfrom
martincostello:gh-2719

Conversation

@martincostello
Copy link
Copy Markdown
Member

Fixes #2719

Changes

Update OpenTelemetry.Instrumentation.AWS to depend on v4 of the AWS SDK for .NET.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Apr 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.51%. Comparing base (71655ce) to head (d8bb181).
Report is 820 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
- Coverage   73.91%   69.51%   -4.41%     
==========================================
  Files         267      394     +127     
  Lines        9615    15871    +6256     
==========================================
+ Hits         7107    11032    +3925     
- Misses       2508     4839    +2331     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 85.67% <ø> (?)
unittests-Exporter.Geneva 52.84% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.61% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 90.65% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 83.83% <ø> (?)
unittests-Instrumentation.AspNet 76.79% <ø> (?)
unittests-Instrumentation.AspNetCore 70.32% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.10% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 74.09% <ø> (?)
unittests-Instrumentation.Owin 88.41% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.ServiceFabricRemoting 34.54% <ø> (?)
unittests-Instrumentation.SqlClient 87.81% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.63% <ø> (?)
unittests-Instrumentation.Wcf 78.57% <ø> (?)
unittests-PersistentStorage 65.88% <ø> (?)
unittests-Resources.AWS 75.00% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 394 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Apr 29, 2025
@martincostello martincostello marked this pull request as ready for review April 29, 2025 09:44
@martincostello martincostello requested a review from a team as a code owner April 29, 2025 09:44
@ppittle
Copy link
Copy Markdown
Member

ppittle commented Apr 29, 2025

@martincostello - could you comment on this point I raised about versioning here: #2719 (comment)

@ppittle
Copy link
Copy Markdown
Member

ppittle commented Apr 29, 2025

@martincostello - this looks good to me! Only concerns are around communicating that bumping the aws sdk v3 to v4 has breaking changes.

But from the SIG meeting on April 29, Open Telemetry core is about to do a Minor version release to 1.12. I think it would be nice to get this change in ASAP and then release the AWS Open Telemetry libraries as 1.12.0. This way we have a minor bump -and-continue to track the same version as open telemetry core library.

@martincostello
Copy link
Copy Markdown
Member Author

@ppittle I don't have any particularly strong feelings on the version. I assumed 1.{1 more than the last release}.0 would be the minimum. A full major version feels too much for how the OTel libraries general version themselves.

Bundling this with 1.12.x of the core seems reasonable.

@ppittle
Copy link
Copy Markdown
Member

ppittle commented Apr 30, 2025

UPDATE: Let's merge #2726 first, to better indicate in NuGet the last version that works with AWS SDK v3.

@martincostello - If you change the release notes per my comment, I'm good to approve this.

We can defer final versioning change until the next release - but I concur either a Major or Minor bump would be appropriate. My current thinking is Minor bump.

Update OpenTelemetry.Instrumentation.AWS to depend on v4 of the AWS SDK for .NET.

Resolves open-telemetry#2719.
Add real pull request number.
Initialize `HttpProtocolVersion`.
Update minimum target for .NET Framework to 4.7.2 as 4.6.2 is not supported, otherwise users get `netstandard2.0` instead.
Implement mock property for `net472`.
Update AWSSDK.DynamoDBv2 to 4.0.0.2 to pick up fix for aws/aws-sdk-net#3776.
@martincostello martincostello requested a review from ppittle May 2, 2025 05:59
@rajkumar-rangaraj rajkumar-rangaraj merged commit b01f5f3 into open-telemetry:main May 2, 2025
214 checks passed
@martincostello martincostello deleted the gh-2719 branch May 2, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Support AWS SDK v4

6 participants