[Instrumentation.AWS] Bump minimal AWS SDKs to 3.7.300#1542
Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom Jan 22, 2024
martincostello:bump-aws-sdks
Merged
[Instrumentation.AWS] Bump minimal AWS SDKs to 3.7.300#1542cijothomas merged 1 commit intoopen-telemetry:mainfrom martincostello:bump-aws-sdks
cijothomas merged 1 commit intoopen-telemetry:mainfrom
martincostello:bump-aws-sdks
Conversation
Bump AWS SDKs to 3.7.300 for native AoT support.
martincostello
commented
Jan 20, 2024
test/OpenTelemetry.Instrumentation.AWS.Tests/TestAWSClientInstrumentation.cs
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
+ Coverage 73.91% 80.58% +6.66%
==========================================
Files 267 113 -154
Lines 9615 3054 -6561
==========================================
- Hits 7107 2461 -4646
+ Misses 2508 593 -1915
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
Member
|
FYI @srprash. @atshaw43, @ppittle, @birojnayak, @normj |
normj
approved these changes
Jan 22, 2024
Contributor
normj
left a comment
There was a problem hiding this comment.
Change looks good and @martincostello is correct version 3.7.300 is where the SDK addressed AOT warnings.
Kielek
approved these changes
Jan 22, 2024
cijothomas
approved these changes
Jan 22, 2024
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bump AWS SDKs to 3.7.300 for native AoT support.
Without this change, there are two AoT warnings when building the project from the AWS.Core library.
CHANGELOG.mdupdated for non-trivial changes