Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Feb 28, 2023

Follow up to #1038 where Instana was unpinned from $(OpenTelemetryCoreLatestVersion)
Towards #1031

Changes

Bump OTel 1.4.0, as this version is not supporting .NET Framework 4.6.1 and .NET Core App 3.1
The package will produce libraries for .NET Framework 4.6.2 and test was switched to net7.0;net.60;net462

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek marked this pull request as ready for review February 28, 2023 08:31
@Kielek Kielek requested a review from a team February 28, 2023 08:31
@Kielek
Copy link
Member Author

Kielek commented Feb 28, 2023

@zivaninstana, could you please review?

@Kielek Kielek added the comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana label Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1050 (47a00fe) into main (3d0e0d4) will not change coverage.
The diff coverage is n/a.

❗ Current head 47a00fe differs from pull request most recent head 0b11d0e. Consider uploading reports for the commit 0b11d0e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files         202      202           
  Lines        7678     7678           
=======================================
  Hits         5365     5365           
  Misses       2313     2313           
Impacted Files Coverage Δ
...xporter.Instana/TracerProviderBuilderExtensions.cs 0.00% <ø> (ø)

Copy link
Contributor

@zivaninstana zivaninstana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cijothomas cijothomas merged commit 6f657e4 into open-telemetry:main Mar 1, 2023
@Kielek Kielek deleted the instana-bump-otel-1.4.0 branch March 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants