Update dockerfile for adservice to use different base images#705
Merged
cartersocha merged 7 commits intoopen-telemetry:mainfrom Jan 24, 2023
Merged
Conversation
Signed-off-by: svrnm <neumanns@cisco.com>
github-actions
bot
requested review from
jack-berg,
mateuszrzeszutek and
trask
Contributor
|
10s build time improvement and same size reduction. lgtm |
jack-berg
reviewed
Jan 21, 2023
austinlparker
approved these changes
Jan 23, 2023
Signed-off-by: svrnm <neumanns@cisco.com>
Member
Author
|
followed @jack-berg's comment and changed the builder once again |
Contributor
|
Thanks @svrnm and @jack-berg 🔥 |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Minor change for the adservice: Similar to frauddetectionservice this makes use of the gradle image to save some time downloading gradle (since both use the same gradle image then this even saves some extra time downloading the image). It also replaces the jdk with a jre image for the final image, saves some ~190MB (518 down to 328)