Skip to content

[Frontend] Global img provider#1571

Merged
julianocosta89 merged 10 commits intoopen-telemetry:mainfrom
klucsik:global-img-provider
May 15, 2024
Merged

[Frontend] Global img provider#1571
julianocosta89 merged 10 commits intoopen-telemetry:mainfrom
klucsik:global-img-provider

Conversation

@klucsik
Copy link
Copy Markdown
Contributor

@klucsik klucsik commented May 13, 2024

Changes

Fixes #1570 by moving the image loader to a global scope. This needs a newer next.js version, so some version bumps are also made.
reference on imageloader: https://nextjs.org/docs/pages/api-reference/next-config-js/images

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]
  • Appropriate Helm chart updates in the [helm-charts][]

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label May 13, 2024
@klucsik klucsik marked this pull request as ready for review May 14, 2024 06:37
@klucsik klucsik requested review from a team and julianocosta89 May 14, 2024 06:37
@klucsik klucsik force-pushed the global-img-provider branch from 0360950 to e8d53db Compare May 14, 2024 07:49
@klucsik klucsik changed the title Global img provider [Frontend] Global img provider May 14, 2024
@klucsik klucsik force-pushed the global-img-provider branch from e8d53db to 3b1f12a Compare May 14, 2024 09:08
Copy link
Copy Markdown
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine, problem fixed!

Screenshot 2024-05-14 at 15 04 06

Copy link
Copy Markdown
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @klucsik!

@julianocosta89 julianocosta89 merged commit a82287d into open-telemetry:main May 15, 2024
@klucsik klucsik deleted the global-img-provider branch May 15, 2024 09:02
neamulkabiremon pushed a commit to neamulkabiremon/ultimate-devops-project-demo that referenced this pull request Apr 16, 2025
* Add a global image loader

* update next to 13.0.0

* remove px from width/hegihts nubmers

* bump versions

* bump versions

* bump versions

* remove unecessary spaces

* fix distorted iamge, add some extra memory for stability

* add changelog

* fix checks
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
* Add a global image loader

* update next to 13.0.0

* remove px from width/hegihts nubmers

* bump versions

* bump versions

* bump versions

* remove unecessary spaces

* fix distorted iamge, add some extra memory for stability

* add changelog

* fix checks
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
* Add a global image loader

* update next to 13.0.0

* remove px from width/hegihts nubmers

* bump versions

* bump versions

* bump versions

* remove unecessary spaces

* fix distorted iamge, add some extra memory for stability

* add changelog

* fix checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm-update-required Requires an update to the Helm chart when released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[frontend] images not showing in shopping cart popup

3 participants