Skip to content

[quoteservice] manual metrics, logs export#1519

Merged
julianocosta89 merged 7 commits intoopen-telemetry:mainfrom
brettmc:php-metrics-logs
Apr 11, 2024
Merged

[quoteservice] manual metrics, logs export#1519
julianocosta89 merged 7 commits intoopen-telemetry:mainfrom
brettmc:php-metrics-logs

Conversation

@brettmc
Copy link
Copy Markdown
Contributor

@brettmc brettmc commented Apr 11, 2024

Changes

  • add a manual metric to the php quote service
  • randomize per-item cost to add some variability to quotes
  • bump dependencies to latest
  • fix a monolog deprecation
  • ensure logs are exported per the configured delay

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

- add a manual metric to the php quote service
- randomize per-item cost to add some variability to quotes
- bump dependencies to latest
- fix a monolog deprecation
- ensure logs are exported per the configured delay
@brettmc brettmc requested a review from a team April 11, 2024 00:00
@brettmc
Copy link
Copy Markdown
Contributor Author

brettmc commented Apr 11, 2024

Related to open-telemetry/opentelemetry.io#2669

@puckpuck
Copy link
Copy Markdown
Contributor

I pushed a fix to your branch for the quote service CI trace-based test. Since the returned cost is now randomized, the quote cost check needed to reflect this.

@brettmc
Copy link
Copy Markdown
Contributor Author

brettmc commented Apr 11, 2024

Since the returned cost is now randomized

Thanks, I didn't consider if there might be downstream effects of randomizing the cost.

@julianocosta89 julianocosta89 merged commit d1535f9 into open-telemetry:main Apr 11, 2024
neamulkabiremon pushed a commit to neamulkabiremon/ultimate-devops-project-demo that referenced this pull request Apr 16, 2025
* [quoteservice] adding manual metrics to quoteservice
- add a manual metric to the php quote service
- randomize per-item cost to add some variability to quotes
- bump dependencies to latest
- fix a monolog deprecation
- ensure logs are exported per the configured delay

* update changelog

* fix

* rename variable

* remove total cost from metric attributes

* quote service returns randomized cost

---------

Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
* [quoteservice] adding manual metrics to quoteservice
- add a manual metric to the php quote service
- randomize per-item cost to add some variability to quotes
- bump dependencies to latest
- fix a monolog deprecation
- ensure logs are exported per the configured delay

* update changelog

* fix

* rename variable

* remove total cost from metric attributes

* quote service returns randomized cost

---------

Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
* [quoteservice] adding manual metrics to quoteservice
- add a manual metric to the php quote service
- randomize per-item cost to add some variability to quotes
- bump dependencies to latest
- fix a monolog deprecation
- ensure logs are exported per the configured delay

* update changelog

* fix

* rename variable

* remove total cost from metric attributes

* quote service returns randomized cost

---------

Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants