[chore]: make stop target for all profiles#1427
Merged
austinlparker merged 7 commits intoopen-telemetry:mainfrom Mar 7, 2024
puckpuck:chore.fix-make-stop-target
Merged
[chore]: make stop target for all profiles#1427austinlparker merged 7 commits intoopen-telemetry:mainfrom puckpuck:chore.fix-make-stop-target
austinlparker merged 7 commits intoopen-telemetry:mainfrom
puckpuck:chore.fix-make-stop-target
Conversation
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
… chore.fix-make-stop-target
austinlparker
approved these changes
Mar 7, 2024
neamulkabiremon
pushed a commit
to neamulkabiremon/ultimate-devops-project-demo
that referenced
this pull request
Apr 16, 2025
* stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix stop target Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io>
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
* stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix stop target Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io>
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
* stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * stop does all profiles Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * fix stop target Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
--profiles tests,oddto the make stop target so that all profiles supported by the demo are stopped. This is useful if you use themake run-testsormake run-tracetesting; those scenarios will now be properly stopped.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.