Skip to content

Fix TraceTest after IBM/sarama upgrade#1096

Merged
julianocosta89 merged 2 commits intoopen-telemetry:mainfrom
julianocosta89:FIX/Kafka-TraceTest
Sep 5, 2023
Merged

Fix TraceTest after IBM/sarama upgrade#1096
julianocosta89 merged 2 commits intoopen-telemetry:mainfrom
julianocosta89:FIX/Kafka-TraceTest

Conversation

@julianocosta89
Copy link
Copy Markdown
Member

@julianocosta89 julianocosta89 commented Sep 4, 2023

Changes

Fix: #1091.
After #1083 being merged, some attributes for the Kafka spans have changed and the TraceTests needed to be adapted.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team September 4, 2023 06:07
@julianocosta89
Copy link
Copy Markdown
Member Author

@danielbdias could you take a look?
It looks like it is running fine now:

Running trace-based tests...

✔ Ad Service (http://tracetest-server:11633/testsuite/ad-service-all/run/1)
	✔ Ad: get (http://tracetest-server:11633/test/ad-get-ads/run/1/test) - trace id: 6e95cb3280db9032412f941cadf3ac46
		✔ It returns two ads
		✔ It returns a valid redirectUrl for each ads

✔ Cart Service (http://tracetest-server:11633/testsuite/cart-all/run/1)
	✔ Cart: empty cart (http://tracetest-server:11633/test/cart-empty-cart/run/1/test) - trace id: 751272a40a069b12c8e0f4540f0f9c90
		✔ It emptied the shopping cart with success
		✔ It sent cleaning message to the database
	✔ Cart: add item to cart (http://tracetest-server:11633/test/cart-add-item-to-cart/run/1/test) - trace id: 85740fd25700bf26886577b1e2d506c7
		✔ It added an item correctly into the shopping cart
		✔ It set the cart item correctly on the database
		✔ It returned an empty cart
	✔ Cart: check if cart is populated (http://tracetest-server:11633/test/cart-check-if-cart-is-populated/run/1/test) - trace id: e1f28eaa899ad735b14bb5cd34333ce3
		✔ It retrieved the cart items correctly
		✔ It returned the first item with correct attributes
	✔ Cart: empty cart (http://tracetest-server:11633/test/cart-empty-cart/run/2/test) - trace id: 646d377437656315b03d5b27700ffa28
		✔ It emptied the shopping cart with success
		✔ It sent cleaning message to the database
	✔ Cart: check if cart is empty (http://tracetest-server:11633/test/cart-check-if-cart-is-empty/run/1/test) - trace id: 9cfc36857477ef7b5b74e667af8f9e33
		✔ It retrieved the cart items correctly
		✔ It returned no items

✔ Currency Service (http://tracetest-server:11633/testsuite/currency-service-all/run/1)
	✔ Currency: Convert (http://tracetest-server:11633/test/currency-convert/run/1/test) - trace id: a351ebed345748ce9c04d26a27f93138
		✔ It converts from USD to CAD
		✔ It has more nanos than expected
	✔ Currency: Supported (http://tracetest-server:11633/test/currency-supported/run/1/test) - trace id: afa9a0350f9b1262e95c92e4d9cec02d
		✔ It has a span called "CurrencyService/GetSupportedCurrencies"
		✔ It returns the expected currency codes

✔ Checkout Service (http://tracetest-server:11633/testsuite/checkout-service-all/run/1)
	✔ Checkout: place order (http://tracetest-server:11633/test/checkout-place-order/run/1/test) - trace id: 574da42a9b00595ce107edeb9a9f6884
		✔ It returns a valid order
		✔ It calls the PlaceOrder method successfuly
		✔ It sends an order to be processed asyncronously

✔ Frontend Service (http://tracetest-server:11633/testsuite/frontend-all/run/1)
	✔ Frontend: See Ads (http://tracetest-server:11633/test/frontend-see-adds/run/1/test) - trace id: f169849098a583c25009e975e2faaab1
		✔ It called the frontend with success and got a valid redirectUrl for each ads
		✔ It returns two ads
	✔ Frontend: Get recommendations (http://tracetest-server:11633/test/frontend-get-recommendation/run/1/test) - trace id: 6a7039d2468b7475254e6e1465f9aeca
		✔ It called the frontend with success
		✔ It called ListRecommendations correctly and got 5 products
	✔ Frontend: Browse products (http://tracetest-server:11633/test/frontend-browse-product/run/1/test) - trace id: 79a53dcab36e4c823f4311ffba2d605c
		✔ It called the frontend with success and got a product with valid attributes
		✔ It queried the product catalog correctly for a specific product
	✔ Frontend: Add product to the cart (http://tracetest-server:11633/test/frontend-add-product/run/1/test) - trace id: ceac96a82e797231ff02384d76338a36
		✔ It called the frontend with success
		✔ It added an item correctly into the shopping cart
		✔ It set the cart item correctly on the database
	✔ Frontend: View cart (http://tracetest-server:11633/test/frontend-view-cart/run/1/test) - trace id: b321db86d7b710383200e840d7d1be99
		✔ It called the frontend with success
		✔ It retrieved the cart items correctly
	✔ Frontend: Checking out shopping cart (http://tracetest-server:11633/test/frontend-checkout-shopping-cart/run/1/test) - trace id: 7942753c0df9197756b2d9f5d9a099f9
		✔ It called the frontend with success
		✔ The order was placed
		✔ The user was charged
		✔ The product was shipped
		✔ The cart was emptied
		✔ The order was sent to be processed asyncronously
		✔ The order was sent to accountability
		✔ The order was sent to fraud detection team

✔ Email Service (http://tracetest-server:11633/testsuite/email-service-all/run/1)
	✔ Email: Confirmation (http://tracetest-server:11633/test/email-confirmation/run/1/test) - trace id: c4ad37fa450bc81991bb11cd24d4205b
		✔ It should be called successfully
		✔ It should render a email to send
		✔ It should send an email

✔ Payment Service (http://tracetest-server:11633/testsuite/payment-service-all/run/1)
	✔ Payment: valid credit card (http://tracetest-server:11633/test/payment-valid-credit-card/run/1/test) - trace id: e0369d68a91a5f44c132ac20cf00e944
		✔ It should call Charge method successfully
		✔ It should return a transaction ID
	✔ Payment: invalid credit card (http://tracetest-server:11633/test/payment-invalid-credit-card/run/1/test) - trace id: 49c0f1b2516306ce03593dde51369afc
		✔ It should call Charge method and receive a gRPC error
		✔ It should return a return an gRPC error code to the caller
	✔ Payment: Amex credit card not allowed (http://tracetest-server:11633/test/payment-amex-credit-card-not-allowed/run/1/test) - trace id: 7d61a8ede37fc0a64ef876ab49098cdf
		✔ It should call Charge method and receive a gRPC error
		✔ It should return a return an gRPC error code to the caller
	✔ Payment: expired credit card (http://tracetest-server:11633/test/payment-expired-credit-card/run/1/test) - trace id: 30ad39ae6d4c6ca041a91763f44e7c86
		✔ It should call Charge method and receive a gRPC error
		✔ It should return a return an gRPC error code to the caller

✔ Product Catalog Service (http://tracetest-server:11633/testsuite/product-catalog-service-all/run/1)
	✔ Product: List (http://tracetest-server:11633/test/product-list/run/1/test) - trace id: d9d31ae3d591f2ea502666cb9f3b8c62
		✔ It queried the product catalog correctly
		✔ It returned products with IDs
	✔ Product: Get (http://tracetest-server:11633/test/product-get/run/1/test) - trace id: 5485c6e57788e2d9c6a368686a51b4b8
		✔ It queried the product catalog correctly for a specific product
		✔ It returned a product with valid attributes
	✔ Product: Search (http://tracetest-server:11633/test/product-search/run/1/test) - trace id: 67f937fb439d530b4ef6432ff83ba051
		✔ It called SearchProducts correctly and it returned 1 item
		✔ It returned the desired product

✔ Recommendation Service (http://tracetest-server:11633/testsuite/recommendation-service-all/run/1)
	✔ Recommendation: List products (http://tracetest-server:11633/test/recommendation-list/run/1/test) - trace id: 1170878a2748c0a2dcb510a08d142d1f
		✔ It called ListRecommendations correctly and got 5 products

✔ Shipping Service (http://tracetest-server:11633/testsuite/shipping-service-all/run/1)
	✔ Shipping: Quote (http://tracetest-server:11633/test/shipping-quote/run/1/test) - trace id: 5c570a51ef221be86c5d1113e0c43b2c
		✔ It called GetQuote correctly
		✔ It returned a valid quote
	✔ Shipping: Empty Quote (http://tracetest-server:11633/test/shipping-empty-quote/run/1/test) - trace id: dd60b86aa85ed087bc4e14cf5ebe9034
		✔ It called GetQuote correctly
		✔ It returned a valid quote
	✔ Shipping: Order (http://tracetest-server:11633/test/shipping-order/run/1/test) - trace id: 8679c19b9ccdd2ec1835b9bc6adb6a77
		✔ It called GetQuote correctly
		✔ It returned a trackingId


Tests done! Exit code: 0

@danielbdias
Copy link
Copy Markdown
Contributor

I tested it now, and it is ok! 😄 🎉

@julianocosta89 julianocosta89 merged commit 315b3ea into open-telemetry:main Sep 5, 2023
@julianocosta89 julianocosta89 deleted the FIX/Kafka-TraceTest branch September 5, 2023 06:00
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Fix TraceTest after IBM/sarama upgrade

* changelog
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
* Fix TraceTest after IBM/sarama upgrade

* changelog
cloud-hb pushed a commit to cloud-hb/opentelemetry-demo that referenced this pull request Nov 17, 2025
* Fix TraceTest after IBM/sarama upgrade

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TraceTest - Failing tests

3 participants