Fix TraceTest after IBM/sarama upgrade#1096
Merged
julianocosta89 merged 2 commits intoopen-telemetry:mainfrom Sep 5, 2023
Merged
Fix TraceTest after IBM/sarama upgrade#1096julianocosta89 merged 2 commits intoopen-telemetry:mainfrom
julianocosta89 merged 2 commits intoopen-telemetry:mainfrom
Conversation
Member
Author
|
@danielbdias could you take a look? |
Contributor
|
I tested it now, and it is ok! 😄 🎉 |
danielbdias
approved these changes
Sep 4, 2023
fatsheep9146
approved these changes
Sep 4, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Fix TraceTest after IBM/sarama upgrade * changelog
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
* Fix TraceTest after IBM/sarama upgrade * changelog
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
* Fix TraceTest after IBM/sarama upgrade * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix: #1091.
After #1083 being merged, some attributes for the Kafka spans have changed and the TraceTests needed to be adapted.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsAppropriate documentation updates in the docsAppropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.