Skip to content

Conversation

sivchari
Copy link

Description

Use grpc.NewClient instead of grpc.DialContext

Link to tracking issue

Fixes #13632

Testing

Documentation

@sivchari sivchari requested a review from a team as a code owner August 19, 2025 02:35
@sivchari sivchari requested a review from codeboten August 19, 2025 02:35
@sivchari sivchari changed the title move from DialContext to NewClient [chore] move from DialContext to NewClient Aug 19, 2025
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.64%. Comparing base (b4ad338) to head (337927a).
⚠️ Report is 3 commits behind head on main.

❌ Your project check has failed because the head coverage (87.64%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13663      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.02%     
==========================================
  Files         632      632              
  Lines       39697    39697              
==========================================
- Hits        34798    34794       -4     
- Misses       3654     3657       +3     
- Partials     1245     1246       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-bradley
Copy link
Contributor

evan-bradley commented Aug 19, 2025

I suspect the contrib test failures are due to the fact that NewClient doesn't initiate a connection unlike DialContext, we should be able to fix that somewhat easily.

@sivchari Can you confirm that this doesn't reintroduce #11537? If possible, a basic test would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configgrpc] Move to NewClient
6 participants